Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve conditional import export docs #6228

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Improve conditional import export docs #6228

merged 2 commits into from
Nov 25, 2024

Conversation

mcmah309
Copy link
Contributor

Improve conditional import/export docs

Related to dart-lang/sdk#59575

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@mcmah309 mcmah309 mentioned this pull request Nov 21, 2024
Closed
@MaryaBelanger
Copy link
Contributor

/gcbrun

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 42fb254):

https://dart-dev--pr6228-improve-conditional-import-docs-j8p6uabx.web.app

MaryaBelanger
MaryaBelanger approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @mcmah309, great improvement!

@MaryaBelanger MaryaBelanger merged commit d035064 into dart-lang:main Nov 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryaBelanger MaryaBelanger MaryaBelanger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcmah309 @MaryaBelanger @dart-github-bot